[Lldb-commits] [PATCH] D24846: [CMake] Generate LLDB_REVISION at build time

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 22 21:47:33 PDT 2016


tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.

Looks good.

I think it's fine landing here for now based on your earlier comments about the refactoring effort to get it into LLVM/clang.  I do think it's worth trying to sink it lower when the time is right to do more of that refactoring, though.

Thanks!


https://reviews.llvm.org/D24846





More information about the lldb-commits mailing list