[Lldb-commits] [PATCH] D24850: add hook for calling platform-dependent pre-kill action on a timed out test

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 22 16:23:14 PDT 2016

tfiala added inline comments.

Comment at: packages/Python/lldbsuite/test/dosep.py:238-245
@@ +237,10 @@
+        # runner for our platform.
+        module_name = "lldbsuite.pre_kill_hook." + platform.system().lower()
+        try:
+            import importlib
+            module = importlib.import_module(module_name)
+        except ImportError:
+            # We don't have one for this platform.  Skip.
+            sys.stderr.write("\nwarning: no timeout handler module: " + module_name)
+            return
I suspect we will need to tweak this a bit.  We need to be able to dispatch on more than just the host platform.system(). It may be sufficient to pass along the test platform info as an argument.


More information about the lldb-commits mailing list