[Lldb-commits] [PATCH] D24847: Make OptionGroup::SetValue take a StringRef

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 22 15:57:50 PDT 2016

I took a quick glance, now I remember. It uses a validator, so the
validator has to either update its signature or make a copy. It's also
called by SetValueFromCString, so that has to be updated or make a copy.
Then it spirals out from there.

So yea, the copy is still going to be there, just in a different place
until there's quite a bit more plumbing done
On Thu, Sep 22, 2016 at 3:45 PM Greg Clayton <clayborg at gmail.com> wrote:

> clayborg added a comment.
> no printf fixes are fine. I don't mind if error cases have str().c_str()
> so much.
> https://reviews.llvm.org/D24847
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160922/59966450/attachment.html>

More information about the lldb-commits mailing list