[Lldb-commits] [PATCH] D24847: Make OptionGroup::SetValue take a StringRef

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 22 15:44:33 PDT 2016


clayborg added a comment.

Yeah, don't do any calls that don't need to be converted. Just the ones you need. Should just add 2 StringRef variant functions. Don't feel the need to completely fix OptionValueString or OptionValueUInt64. We can do the full change over in a future CL. See if you can just add the two quick ones.


https://reviews.llvm.org/D24847





More information about the lldb-commits mailing list