[Lldb-commits] [PATCH] D24847: Make OptionGroup::SetValue take a StringRef

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 22 15:36:24 PDT 2016

OptionValueString is actually the next item on my list. I tried it before
this and it was a very big CL, But maybe with this done it will be smaller.

I can try again but if the cl grows too large i think it's better to do it
in a followup. If nothing else so that if a buildbot fails it's easier to
track it down with a more modest sized cl.

For the printing stuff, it might be cleaner to just use an llvm stream and
then pass it to Error::SetErrorString. The %*s macros will look kind of
gross (for the same reason that the PRIx64 style macros look so horrible).

But all these things combined will make a really big CL, I'd rather do it
in chunks. Maybe format strings next then OptionValueString?
On Thu, Sep 22, 2016 at 3:15 PM Greg Clayton <clayborg at gmail.com> wrote:

> clayborg added a comment.
> I am not saying we have to do the printf changes, I was just seeing what
> you think. I would like to see the StringRef variants of functions put in
> as part of this.
> https://reviews.llvm.org/D24847
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160922/2816fea9/attachment.html>

More information about the lldb-commits mailing list