[Lldb-commits] [PATCH] D24764: Refactor NativeRegisterContextLinux_x86_64 code.
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Tue Sep 20 13:26:59 PDT 2016
labath added inline comments.
================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:805
@@ -827,2 +804,3 @@
+ if (m_xstate_type == XStateType::Invalid) {
if (const_cast<NativeRegisterContextLinux_x86_64 *>(this)->ReadFPR().Fail())
return false;
----------------
Then I think we should make that non-const as well. I mean, what's the point of making it const if it does actually modify the state of the object. Either that, or implement it in a way that does not modify the state.
https://reviews.llvm.org/D24764
More information about the lldb-commits
mailing list