[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Tue Sep 20 13:19:33 PDT 2016
zturner requested changes to this revision.
zturner added a comment.
This revision now requires changes to proceed.
When I run ninja check-lldb with this patch, every single test crashes. It's crashing at ObjectFilePECOFF.cpp:583, which does this:
const char *symbol_name_cstr =
symtab_data.PeekCStr(name_address - data_start);
the symbol name returned is null, which it's trying to assign to a std::string.
I confirmed that without your patch everything works.
The CMake command line I am using is
`cmake -G Ninja -DLLDB_TEST_COMPILER=D:\src\llvmbuild\ninja_release\bin\clang.exe -DPYTHON_HOME=C:\Python35`
Let me know if you have trouble reproducing this crash, but it will need to be fixed before this CL can go in.
More information about the lldb-commits