[Lldb-commits] [PATCH] D24749: [CMake] Initial support for LLDB.framework

[Chris Bieneman via lldb-commits]

beanz added a comment.

I've tested this on OS X with and without `LLDB_BUILD_FRAMEWORK` set, and check-lldb works in both cases. I would expect it to also work on Linux and Windows. The change should be NFC if `LLDB_BUILD_FRAMEWORK=Off`.


================
Comment at: scripts/Python/finishSwigPythonLLDB.py:397
@@ -396,3 +396,3 @@
             strBuildDir = os.path.join("..", "..", "..", "..")
-        strSrc = os.path.normcase(os.path.join(strBuildDir, vstrSrcFile))
+    strSrc = os.path.normcase(os.path.join(strBuildDir, vstrSrcFile))
 
----------------
zturner wrote:
> Was this line intentional?
Yes, previously when -m was not passed it returned on line 386, I've removed that return, and need to construct strSrc regardless of the branch above.

================
Comment at: source/API/CMakeLists.txt:9
@@ -8,1 +8,3 @@
 
+option(LLDB_BUILD_FRAMEWORK "Build the Darwin LLDB.framework" Off)
+
----------------
tfiala wrote:
> zturner wrote:
> > Is there any reason to have this off when building on OSX?  Is there any value in having it not be an option at all, but just if you're on Darwin, you just always get a Framework?
> I mentioned to Chris that I wasn't sure if the Google folks (or maybe Dawn) that build with the CMake build might want to keep it building the old way.
> 
> I'd be all for only building only the framework way with CMake if nobody else particularly cared.  That would simplify things.  But I don't want to force it if anybody else cares.
> 
> Our goal is to get the CMake-based build producing the same exact thing as our Xcode-based build.
Since this is new functionality that changes the build system behavior it is always best to leave it optional and off by default so that it can be properly tested and won't impact consumers. For users who don't set `LLDB_BUILD_FRAMEWORK=On` this patch should be NFC.

Additionally since OS X is Unix it would be undesirable to force OS X to always build a framework because some users may prefer unix-style builds (me being one of them). Whether or not the default build should be a framework I think is a question we can ask ourselves later once this patch is fully tested and after subsequent patches to fix the install targets. 


https://reviews.llvm.org/D24749