[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

Aetf via lldb-commits lldb-commits at lists.llvm.org
Sun Sep 18 14:17:26 PDT 2016


aetf created this revision.
aetf added a reviewer: ki.stfu.
aetf added a subscriber: lldb-commits.
Herald added a subscriber: ki.stfu.

Some of the mi commands implemented in lldb-mi are incomplete/not confirming to the spec.
- `gdb-show` and `gdb-set` doesn't support getting/setting `disassembly-flavor`
- `environment-cd` should also change the working directory for inferior
- debugger CLI output should be printed as console-stream-output record, rather than dump directly
to stdout
- `target-select` should provide inner error message in mi response

Related bug report:
- https://llvm.org/bugs/show_bug.cgi?id=28026
- https://llvm.org/bugs/show_bug.cgi?id=28718
- https://llvm.org/bugs/show_bug.cgi?id=30265

https://reviews.llvm.org/D24711

Files:
  tools/lldb-mi/MICmdCmdEnviro.cpp
  tools/lldb-mi/MICmdCmdGdbSet.cpp
  tools/lldb-mi/MICmdCmdGdbSet.h
  tools/lldb-mi/MICmdCmdGdbShow.cpp
  tools/lldb-mi/MICmdCmdGdbShow.h
  tools/lldb-mi/MICmdCmdMiscellanous.cpp
  tools/lldb-mi/MICmdCmdTarget.cpp
  tools/lldb-mi/MICmnMIOutOfBandRecord.cpp
  tools/lldb-mi/MICmnMIOutOfBandRecord.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24711.71760.patch
Type: text/x-patch
Size: 8951 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160918/5bf9e6b4/attachment.bin>


More information about the lldb-commits mailing list