[Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

[Muhammad Omair Javaid via lldb-commits]

omjavaid updated this revision to Diff 71633.
omjavaid added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.

I have added a new test case that tests suggested scnario without changing any previous test cases.

Also I have made sure we re validate all watchpoint installed on thread resume to make sure we have the latest values assigned to hardware watchpoint registers.

This passes on ARM (RaspberryPi3, Samsung Chromebook). I have not yet tested on android.

This will fail on targets which dont support multiple watchpoint slots.

Also this should fail on AArch64 which I am currently working on.


https://reviews.llvm.org/D24610

Files:
  packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/Makefile
  packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/TestWatchpointMultipleSlots.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/main.c
  source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
  source/Plugins/Process/Linux/NativeThreadLinux.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24610.71633.patch
Type: text/x-patch
Size: 16745 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160916/e290686c/attachment-0001.bin>