[Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

[Zachary Turner via lldb-commits]

zturner accepted this revision.
zturner added a comment.

lgtm from my point of view after `LLDB_TEST_CXX_COMPILER` and `LLDB_TEST_C_COMPILER` are added.

One question: Currently the tests appear to run all commands until the end of the file, and then do 1 pass over the output through `FileCheck`.  Is this correct?

We have a lot of tests where the command to run next depends on the output of a previous command.  If the test is running LLDB commands rather than using the python api, this means you need some pexpect-style solution that can read output and send input to the process as it's running.  Does lit have anything like this?  I'm pretty sure the answer is no, but just want to check.  We can punt on supporting this type of test until later, just want to find out if it's already supported.


https://reviews.llvm.org/D24591