[Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 14 16:18:40 PDT 2016
zturner added inline comments.
Comment at: lit/CMakeLists.txt:14
@@ -13,1 +13,3 @@
+option(LLDB_TEST_CLANG "Use in-tree clang when testing lldb" Off)
> The `LLDB_TEST_COMPILER` option doesn't signify that it is using an in-tree or out-of-tree compiler which is significant if we're going to tie the test target to depending on the clang target. We could support that option in addition to this one, but I see them as distinctly different.
At the same time, setting `LLDB_TEST_COMPILER` to something and `LLDB_TEST_CLANG` seem to be incompatible with each other. Should we error if both of them are set?
Another possibility is to allow one to set `LLDB_TEST_COMPILER` to be set to a magic value like `<in-tree>`
More information about the lldb-commits