[Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

[Jim Ingham via lldb-commits]

jingham added a comment.

Writing tests this way means we're going back to testing the command line commands.  That was what gdb did for the most part, and you ended up terrified of making changes that might effect command output, not because the change was hard but because knew you would have to go waste a day or your life making annoying fixes to a whole bunch of tests.  This happened in lldb with the command line tests we did have, specifically with the breakpoint reporting.   So I had to go make functions for setting breakpoints and making sure they got set correctly - and change all the tests to use them - so I could change just one place when I added output to breakpoint reporting.

We made a choice a while ago to favor tests using the SB API's for this reason.  Is the virtue of lit sufficient that we really want to go back on this decision?


https://reviews.llvm.org/D24591