[Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 13 16:14:56 PDT 2016


tfiala updated this revision to Diff 71253.
tfiala added a comment.

This change does the following:

- Removes storing the ANSI escape support flag from the stream and directly consults the Debugger::GetUseColor() method.  We should be able to change this during a debug session (via settings set use-color {true|false}) and have it take effect immediately.
- Adds a test case for the use-color case.  (The previous change only had a test for the no-color case).

This is ready for a proper review.


https://reviews.llvm.org/D20835

Files:
  include/lldb/API/SBSourceManager.h
  include/lldb/Core/Debugger.h
  include/lldb/Core/Disassembler.h
  include/lldb/Core/SourceManager.h
  packages/Python/lldbsuite/test/lldbtest.py
  packages/Python/lldbsuite/test/settings/TestSettings.py
  packages/Python/lldbsuite/test/source-manager/TestSourceManager.py
  scripts/interface/SBSourceManager.i
  source/API/SBSourceManager.cpp
  source/Commands/CommandObjectSource.cpp
  source/Core/Debugger.cpp
  source/Core/Disassembler.cpp
  source/Core/SourceManager.cpp
  source/Target/StackFrame.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20835.71253.patch
Type: text/x-patch
Size: 26336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160913/af355e9e/attachment-0001.bin>


More information about the lldb-commits mailing list