[Lldb-commits] [PATCH] D24495: A little bit more pointer safety in the Breakpoint code
Jim Ingham via lldb-commits
lldb-commits at lists.llvm.org
Tue Sep 13 10:50:57 PDT 2016
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks fine. The only bad effect of making a CommandBaton, then going out of your way to put it in a plain old BatonSP before passing it to us rather than a CommandBatonSP is that the serialization code won't know it is a command baton, and won't serialize it. We use the llvm isa stuff in a bunch of places so if this becomes a problem it would be natural to fix it that way.
More information about the lldb-commits