[Lldb-commits] [PATCH] D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS

[Nitesh Jain via lldb-commits]

nitesh.jain added inline comments.

================
Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:972
@@ -968,4 +971,3 @@
 
           f0_value.GetData(f0_data);
 
----------------
The issued was while setting f0_data and f2_data successively via RegisterValue.GetData. Since RegisterValue.GetData() will internally call Scalar::GetBytes() which contain static member (flt_val and db1_val) for floating point type . Hence two successive calls to set data for m_type float/double will cause  the content of f0_data to be overwritten with the content of f2_value.

Scalar::GetBytes() const
{
    const uint64_t *apint_words;
    const uint8_t *bytes;
    static float_t flt_val;
    static double_t dbl_val;
    static uint64_t swapped_words[4];
    
    ...
    ...
    ...
}


https://reviews.llvm.org/D24498