[Lldb-commits] [PATCH] D23883: Remove MIUtilParse (no longer used)

[Jim Ingham via lldb-commits]

> On Sep 10, 2016, at 11:26 PM, Zachary Turner via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> I don't think requiring user install of six would work, lldb should just work out of the box.  Renaming it to lldb_six might work.
> 
> Also yes using llvm regex everywhere would be wonderful, I honestly have no idea why mi was developed the way it was with an aversion to using llvm classes

I think lldb-mi was originally conceived as a stand-alone module that could be built just using the SB API's, with which we promise to maintain compatibility.  lldb doesn't make llvm API's available (nor, I think, do we want to do that), so using them complicates the build more than somewhat.  Now that lldb-mi is shipped as part of lldb there's less reason for this.

Jim


> 
> On Sat, Sep 10, 2016 at 11:16 PM Michał Górny via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> mgorny added a comment.
> 
> In https://reviews.llvm.org/D23883#539442, @krytarowski wrote:
> 
> > It looks good. Remaining TODO for standalone builds:
> >
> > - sanitize six.py usage (it's installed into system-wide directory, where standard py-six lands)
> 
> 
> How would you prefer handling it? Can we just kill it and rely on user installing it system-wide or via pip?
> 
> > - bump cmake_minimum_required(VERSION 2.8.12.2) to 3.4.3 in cmake/modules/LLDBStandalone.cmake Final bits for Windows:
> 
> > - eliminate the usage of ../lib/Support/regex_impl.h in RegularExpression.h
> 
> 
> Wouldn't it be actually better to kill that regex implementation as well, and use the class provided by LLVMSupport everywhere? I started with the other since it caused direct build issues on Linux but I think I could try to kill this one as well.
> 
> 
> https://reviews.llvm.org/D23883
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits