[Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

[Ilia K via lldb-commits]

ki.stfu added a comment.

PS: I think it will look like:

  Index: tools/lldb-mi/MICmdCmdBreak.cpp
  ===================================================================
  --- tools/lldb-mi/MICmdCmdBreak.cpp	(revision 281191)
  +++ tools/lldb-mi/MICmdCmdBreak.cpp	(working copy)
  @@ -84,8 +84,7 @@
     // Not implemented m_setCmdArgs.Add(new CMICmdArgValOptionShort(
     // m_constStrArgNamedHWBrkPt, false, false));
     m_setCmdArgs.Add(new CMICmdArgValOptionShort(
  -      m_constStrArgNamedPendinfBrkPt, false, true,
  -      CMICmdArgValListBase::eArgValType_StringQuotedNumberPath, 1));
  +      m_constStrArgNamedPendinfBrkPt, false, true));
     m_setCmdArgs.Add(new CMICmdArgValOptionShort(m_constStrArgNamedDisableBrkPt,
                                                  false, false));
     // Not implemented m_setCmdArgs.Add(new CMICmdArgValOptionShort(
  @@ -99,7 +98,7 @@
     m_setCmdArgs.Add(new CMICmdArgValOptionShort(
         m_constStrArgNamedRestrictBrkPtToThreadId, false, true,
         CMICmdArgValListBase::eArgValType_Number, 1));
  -  m_setCmdArgs.Add(new CMICmdArgValString(m_constStrArgNamedLocation, false,
  +  m_setCmdArgs.Add(new CMICmdArgValString(m_constStrArgNamedLocation, true,
                                             true, false, false, true));
     return ParseValidateCmdOptions();
   }
  @@ -158,12 +157,7 @@
       m_strArgOptionThreadGrp = CMIUtilString::Format("i%d", nThreadGrp);
     }
     m_bBrkPtIsPending = pArgPendingBrkPt->GetFound();
  -  if (pArgLocation->GetFound())
  -    m_brkName = pArgLocation->GetValue();
  -  else if (m_bBrkPtIsPending) {
  -    pArgPendingBrkPt->GetExpectedOption<CMICmdArgValString, CMIUtilString>(
  -        m_brkName);
  -  }
  +  m_brkName = pArgLocation->GetValue();
     if (pArgIgnoreCnt->GetFound()) {
       pArgIgnoreCnt->GetExpectedOption<CMICmdArgValNumber, MIuint>(
           m_nBrkPtIgnoreCount);


Repository:
  rL LLVM

https://reviews.llvm.org/D23026