[Lldb-commits] [PATCH] D24369: [support] copying JSON parser/writer from lldb

[Chandler Carruth via lldb-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D24369#538472, @zturner wrote:

> In https://reviews.llvm.org/D24369#538422, @aizatsky wrote:
>
> > > I'm a bit surprised there's not already a json parser in LLVM.  Maybe there's a reason for it.  I think this CL needs a few more reviewers on the LLVM side, so I'm adding a few people.
> >
>


There is already a JSON parser in LLVM.

> > I can't actually find json parser within clang-tidy. Only references that I see lead eventually to YAML parsing:

> 

> 

> I was thinking of `lib/Tooling/JSONCompilationDatabase`, but looking at it, it seems to be pretty specialized and doesn't support arbitrary JSON.


It uses the YAML parser because JSON is a strict subset of YAML: https://en.wikipedia.org/wiki/JSON#YAML

Please don't add a JSON parser to LLVM. I would much rather teach LLDB to use the YAML parser and improve that parser if and where useful.


https://reviews.llvm.org/D24369