[Lldb-commits] [lldb] r280922 - Fix test breakage in r280919

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 8 04:09:14 PDT 2016


Author: labath
Date: Thu Sep  8 06:09:14 2016
New Revision: 280922

URL: http://llvm.org/viewvc/llvm-project?rev=280922&view=rev
Log:
Fix test breakage in r280919

It turns out that self.dbg.GetSelectedPlatform().GetTriple() is not a good way
to get the triple of the process, as it returns the incorrect triple in case of a
32-bit process running on a 64-bit platform.

Instead, go the long way round and ask the stub for the process triple. This
fixes the test for i386.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py?rev=280922&r1=280921&r2=280922&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py Thu Sep  8 06:09:14 2016
@@ -14,10 +14,14 @@ class TestGdbRemoteModuleInfo(gdbremote_
 
     def module_info(self):
         procs = self.prep_debug_monitor_and_inferior()
+        self.add_process_info_collection_packets()
+        context = self.expect_gdbremote_sequence()
+        info = self.parse_process_info_response(context)
+
         self.test_sequence.add_log_lines([
             'read packet: $jModulesInfo:[{"file":"%s","triple":"%s"}]]#00' % (
                 lldbutil.append_to_process_working_directory("a.out"),
-                self.dbg.GetSelectedPlatform().GetTriple()),
+                info["triple"].decode('hex')),
             {"direction": "send",
              "regex": r'^\$\[{(.*)}\]\]#[0-9A-Fa-f]{2}',
              "capture": {1: "spec"}},




More information about the lldb-commits mailing list