[Lldb-commits] [PATCH] D24251: LLDB: API for Permission of object file's sections

Eugene Zelenko via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 7 10:17:59 PDT 2016


Eugene.Zelenko added inline comments.

================
Comment at: source/API/SBSection.cpp:257
@@ +256,3 @@
+    SectionSP section_sp(GetSP());
+    if (section_sp.get())
+        return section_sp->GetPermissions();
----------------
You don't need to use get(), because smart pointers have http://en.cppreference.com/w/cpp/memory/shared_ptr/operator_bool. Will be good idea to remove it in other conditions in this file.


https://reviews.llvm.org/D24251





More information about the lldb-commits mailing list