[Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

[Zachary Turner via lldb-commits]

For #2 you can use llvm::GetProcessTriple(), i will think about #1 when I
have a chance to look at the code
On Sat, Sep 3, 2016 at 2:38 PM Vyacheslav Karpukhin <
vyacheslav at karpukhin.com> wrote:

> stigger added a comment.
>
> In https://reviews.llvm.org/D20041#533725, @zturner wrote:
>
> > How difficult would be it be to eliminate the `PathSyntax` enumeration
> entirely and update every user of `PathSyntax` to use a triple instead?
>
>
> I've attempted to do it and hit two issues which I'm not sure how to
> resolve:
>
> 1. SymbolFilePDB.cpp:358 uses FileSpec with explicit `ePathSyntaxWindows`.
> It's possible to do something like `llvm::Triple("unknown", "unknown",
> "windows")`, but that kind of smells.
> 2. HostInfoBase.cpp:63 has a bunch of FileSpecs with
> `ePathSyntaxHostNative`, but at that moment it is not yet possible to use
> `HostInfo::GetArchitecture()`, because it's being constructed.
>
>
> https://reviews.llvm.org/D20041
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160903/720a4e34/attachment.html>