[Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

[Zachary Turner via lldb-commits]

zturner added a subscriber: zturner.
zturner added a comment.

I like the approach taken here in general.

One thing that I wonder about, if we have the Triple, why do we even need the PathSyntax at all?  In light of the fact that not all Posix filesystems are case sensitive, this calls into question the usefulness of the Path Syntax since it is both unnecessary and insufficient.

I do think that `FileSpec` should be completely independent of `Host`.  Any host detection code should be in `FileSystem.h` and any remote detection code should be in `Platform` somewhere.  Both of those are independent of this patch though.

How difficult would be it be to eliminate the `PathSyntax` enumeration entirely and update every user of `PathSyntax` to use a triple instead?


https://reviews.llvm.org/D20041