[Lldb-commits] [PATCH] D24074: Fixup TestPyObjSynthProvider.py and enable it again

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 31 10:49:58 PDT 2016


labath added inline comments.

================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py:19
@@ -18,2 +18,3 @@
     mydir = TestBase.compute_mydir(__file__)
+    NO_DEBUG_INFO_TESTCASE = True
 
----------------
granata.enrico wrote:
> I assume this only implies not to build for *all* debug info formats, but still allows an a.out to be built?
> 
> If so, fine by me
Acknowledged.

================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/provider.py:3
@@ -2,2 +2,3 @@
 import lldb.formatters
+import lldb.formatters.synth
 
----------------
granata.enrico wrote:
> That didn't seem to be necessary on macOS. Not sure what the difference is, but anyway, doesn't look wrong.
Yes.. very odd, but it did not work without it for me.


Repository:
  rL LLVM

https://reviews.llvm.org/D24074





More information about the lldb-commits mailing list