[Lldb-commits] [PATCH] D24074: Fixup TestPyObjSynthProvider.py and enable it again

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 31 05:28:02 PDT 2016


labath created this revision.
labath added a reviewer: granata.enrico.
labath added a subscriber: lldb-commits.

- copies the new file in the cmake build
- adds an additional import statement
- marks the test as no-debug-info specific, as it seems to be testing a python feature

https://reviews.llvm.org/D24074

Files:
  packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/provider.py
  scripts/Python/finishSwigPythonLLDB.py

Index: scripts/Python/finishSwigPythonLLDB.py
===================================================================
--- scripts/Python/finishSwigPythonLLDB.py
+++ scripts/Python/finishSwigPythonLLDB.py
@@ -793,6 +793,7 @@
         # Having these files copied here ensure that lldb/formatters is a
         # valid package itself
         listPkgFiles = [os.path.join(strRoot, "examples", "summaries", "cocoa", "cache.py"),
+                        os.path.join(strRoot, "examples", "summaries", "synth.py"),
                         os.path.join(strRoot, "examples", "summaries", "cocoa", "metrics.py"),
                         os.path.join(strRoot, "examples", "summaries", "cocoa", "attrib_fromdict.py"),
                         os.path.join(strRoot, "examples", "summaries", "cocoa", "Logger.py")]
Index: packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/provider.py
===================================================================
--- packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/provider.py
+++ packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/provider.py
@@ -1,5 +1,6 @@
 import lldb
 import lldb.formatters
+import lldb.formatters.synth
 
 class SyntheticChildrenProvider(lldb.formatters.synth.PythonObjectSyntheticChildProvider):
     def __init__(self, value, internal_dict):
Index: packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py
===================================================================
--- packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py
+++ packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py
@@ -16,8 +16,8 @@
 class PyObjectSynthProviderTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
+    NO_DEBUG_INFO_TESTCASE = True
 
-    @expectedFailureAll(oslist=["linux"])
     def test_print_array(self):
         """Test that expr -Z works"""
         self.build()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24074.69836.patch
Type: text/x-patch
Size: 2079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160831/46120264/attachment.bin>


More information about the lldb-commits mailing list