[Lldb-commits] [PATCH] D23884: Add StructuredData unit tests; remove JSON parsing string copy

[Todd Fiala via lldb-commits]

tfiala created this revision.
tfiala added reviewers: clayborg, labath, jasonmolenda.
tfiala added a subscriber: lldb-commits.

This change does the following:
* Adds three new unit test entries to test handling of $JSON-asyc: packets.  Thanks to Pavel for making that whole section of code easily unit testable!
* Tightens up the packet verification on reception of a $JSON-async: packet.
* Changes the StructuredData JSON parsing method to eliminate an unnecessary string copy and instead take a const char*. Fixes up call sites.
* Xcode project: adds a needed TERM env var to the running portion of the gtest debugging scheme.

https://reviews.llvm.org/D23884

Files:
  include/lldb/Core/StructuredData.h
  source/Core/StructuredData.cpp
  source/Host/macosx/Host.mm
  source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23884.69269.patch
Type: text/x-patch
Size: 13454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160825/c3ab367b/attachment-0001.bin>