[Lldb-commits] [lldb] r279672 - fix darwin_log test errors on macOS < 10.12

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 24 14:40:29 PDT 2016


Author: tfiala
Date: Wed Aug 24 16:40:29 2016
New Revision: 279672

URL: http://llvm.org/viewvc/llvm-project?rev=279672&view=rev
Log:
fix darwin_log test errors on macOS < 10.12

The newer event-based tests I added neglected to do the
macOS 10.12 check in the setup.  This caused earlier macOS
test suite runs to attempt to compile code that doesn't exist.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/darwin_log.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/darwin_log.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/darwin_log.py?rev=279672&r1=279671&r2=279672&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/darwin_log.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/darwin_log.py Wed Aug 24 16:40:29 2016
@@ -296,6 +296,15 @@ class DarwinLogEventBasedTestBase(lldbte
         # Call super's setUp().
         super(DarwinLogEventBasedTestBase, self).setUp()
 
+        # Until other systems support this, exit
+        # early if we're not macOS version 10.12
+        # or greater.
+        version = platform.mac_ver()[0].split('.')
+        if ((int(version[0]) == 10) and (int(version[1]) < 12) or
+            (int(version[0]) < 10)):
+                self.skipTest("DarwinLog tests currently require macOS 10.12+")
+                return
+
         # Source filename.
         self.source = 'main.c'
 




More information about the lldb-commits mailing list