[Lldb-commits] [lldb] r279345 - Remove a test that depends on knowing all compiler's register allocation schemes.

[Jim Ingham via lldb-commits]

Author: jingham
Date: Fri Aug 19 17:58:26 2016
New Revision: 279345

URL: http://llvm.org/viewvc/llvm-project?rev=279345&view=rev
Log:
Remove a test that depends on knowing all compiler's register allocation schemes.

This test was using a condition that would compare a variable against the register that would hold
it.  It was failing with clang on arm64 because clang put the variable on the stack.

This is not a supportable way to write tests.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py?rev=279345&r1=279344&r2=279345&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py Fri Aug 19 17:58:26 2016
@@ -108,29 +108,6 @@ class BreakpointConditionsTestCase(TestB
             startstr = '(int) val = 1')
 
         self.runCmd("process kill")
-        self.runCmd("breakpoint disable")
-
-        self.runCmd("breakpoint set -p Loop")
-        arch = self.getArchitecture()
-        if arch in ['x86_64', 'i386']:
-            self.runCmd("breakpoint modify -c ($eax&&i)")
-        elif arch in ['aarch64']:
-            self.runCmd("breakpoint modify -c ($x0&&i)")
-        elif arch in ['arm']:
-            self.runCmd("breakpoint modify -c ($r0&&i)")
-        elif re.match("mips",arch):
-            self.runCmd("breakpoint modify -c ($r2&&i)")
-        elif arch in ['s390x']:
-            self.runCmd("breakpoint modify -c ($r2&&i)")
-        self.runCmd("run")
-
-        self.expect("process status", PROCESS_STOPPED,
-            patterns = ['Process .* stopped'])
-
-        self.runCmd("continue")
-
-        self.expect("process status", PROCESS_EXITED,
-            patterns = ['Process .* exited'])
 
     def breakpoint_conditions_python(self):
         """Use Python APIs to set breakpoint conditions."""