[Lldb-commits] [PATCH] D23659: Remove the last manually constructed packet from gdb-remote register context + small refactor
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 18 06:03:02 PDT 2016
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
The tricky part here was that the exisiting implementation of WriteAllRegisters was expecting
hex-encoded data (as that was what the first implementation I replaced was using, but here we had
binary data to begin with. I thought the read/write register functions would be more useful if
they handled the hex-encoding themselves (all the other client functions provide the responses in
a more-or-less digested form). The read functions return a DataBuffer, so they can allocate as
much memory as they need to, while the write functions functions take an llvm::ArrayRef, as that
can be constructed from pretty much anything.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 24554 bytes
Desc: not available
More information about the lldb-commits