[Lldb-commits] [PATCH] D23545: Minidump parsing

[Dimitar Vlahovski via lldb-commits]

dvlahovski added inline comments.

================
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:31-35
@@ +30,7 @@
+    // the signature might be byte swapped
+    data.SetByteOrder(lldb::eByteOrderBig);
+    *offset -= 4;
+    signature = data.GetU32(offset);
+    if (signature == MINIDUMP_SIGNATURE)
+        return true;
+
----------------
zturner wrote:
> Why would this be true?  Is there a minidump specification somewhere that says that both big endian and little endian are valid byte orderings?  I would expect that being a Microsoft created format, it should always be little endian, and if there is a file in big endian we can consider it corrupt.
I didn't find anything in the MS documentation about the minidump's endianess.
I am doing this because breakpad does this too: https://chromium.googlesource.com/breakpad/breakpad/+/master/src/processor/minidump.cc#4384



https://reviews.llvm.org/D23545