[Lldb-commits] [PATCH] D23545: Minidump parsing

[Zachary Turner via lldb-commits]

I would prefer to use llvm types to do the parsing wherever possible. Why
do we need DataExtractor? If the only reason is to force little endian,
just use the types in llvm/Endian.h
On Tue, Aug 16, 2016 at 8:13 AM Dimitar Vlahovski via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> dvlahovski updated this revision to Diff 68180.
> dvlahovski added a comment.
>
> Fixing a little bug - should get the byteorder
>
> after calling SignatureMatchAndSetByteOrder
>
>
> https://reviews.llvm.org/D23545
>
> Files:
>   cmake/LLDBDependencies.cmake
>   source/Plugins/Process/CMakeLists.txt
>   source/Plugins/Process/minidump/CMakeLists.txt
>   source/Plugins/Process/minidump/MinidumpParser.cpp
>   source/Plugins/Process/minidump/MinidumpParser.h
>   source/Plugins/Process/minidump/MinidumpTypes.cpp
>   source/Plugins/Process/minidump/MinidumpTypes.h
>   unittests/Process/CMakeLists.txt
>   unittests/Process/minidump/CMakeLists.txt
>   unittests/Process/minidump/Inputs/linux-x86_64.dmp
>   unittests/Process/minidump/MinidumpParserTest.cpp
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160816/67e936ff/attachment.html>