[Lldb-commits] [PATCH] D23406: Fix a race in Broadcaster/Listener interaction

[Jim Ingham via lldb-commits]

jingham accepted this revision.
jingham added a comment.

Yes, sorry.  I seem to have trouble with remembering the Action dropdown...  Thanks for figuring this out - and apologies for any hair loss we inadvertently caused you!

I doubt it is important to use SmallVector rather than std::vector in this case, but not doing it because the thing is opaque does not seem the right deciding factor.  There will clearly be cases where it is beneficial.  Along with all the other testing improvements we need to do in our spare time, it might be good to write some tests for these formatters so they don't regress if they have.

gdb's build process writes a .gdbinit file into the build products that set up a convenient environment for debugging gdb with gdb.  To use the gdb ones, you have to cd into the gdb directory, and debug from there.  That works but is a little inelegant.  I don't have a better idea right now, but it would be cool to come up with a way to do the same thing in lldb, so that if you're debugging lldb you get both useful formatters for lldb & llvm/clang.

Another in the continuing series of "What other people should do with their spare time..."

Jim


https://reviews.llvm.org/D23406