[Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

[Pavel Labath via lldb-commits]

labath added a comment.

Ok. After some though I have come up with this:

- leave the tool computation logic as it is in the last version of your patch
- add the ability to override the tool values via environment variables. Basically this would mean using `TOOL ?= value` instead of `TOOL = value`. I don't really like that pattern but it is already used in a lot of places, so it's not anything new.

Then, we could use `--env OBJCOPY=objcopy` dotest.py argument to override the default tool computation logic, where it does not compute the correct values. There is only one gotcha here, and that is that make already provides a default value for `AR`, so `AR ?= whatever` would be a noop. Therefore, we would need to use a different variable name for the tool (`ARCHIVE`?). I don't think that the different name would be too confusing, since in the case of darwin we are already setting the value to `libtool`, which is in no relation to `AR`.

What do you think about that?


https://reviews.llvm.org/D20386