[Lldb-commits] [PATCH] D23406: Fix a race in Broadcaster/Listener interaction
Jim Ingham via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 11 15:55:04 PDT 2016
jingham added a comment.
The patch seems correct to me.
I don't have a strong opinion about std::vector vrs. SmallVector. These are temporary objects, so the size of the container doesn't matter, and I doubt this code is hot enough in normal lldb sessions that the difference between in performance between the two will matter. Maybe the SmallVector data formatter (llvm/utils/lldbDataFormatters.py) works, or if it doesn't we should fix it?
More information about the lldb-commits