[Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

[Pierson Lee via lldb-commits]

pieandcakes added a comment.

Hi Ilia,

Thanks for the review. There is another change I do need to make in the Execute() method and probably add some tests.

I reviewed this <https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Breakpoint-Commands.html#GDB_002fMI-Breakpoint-Commands> spec for GDB/MI and it looks like -f should be a flag that says if //location// isn't found, to go ahead and set it as pending. I would assume that if pending flag is set and no //location// is set that it should error. Let me know what you think.

-Pierson


Repository:
  rL LLVM

https://reviews.llvm.org/D23026