[Lldb-commits] [PATCH] D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend

[Luke Drummond via lldb-commits]

ldrumm added a comment.

In https://reviews.llvm.org/D18059#499525, @tfiala wrote:

> In https://reviews.llvm.org/D18059#499522, @ldrumm wrote:
>
> > In https://reviews.llvm.org/D18059#499521, @tfiala wrote:
> >
> > > I've got a fix to make this work in Xcode, but I'm currently stuck behind the missing Condition.cpp from r277011 to verify.
> >
> >
> > Thanks Todd. I don't really deal with XCode, so that's a real help.
>
>
> My pleasure!  We expect to need to do this on the Xcode side since we aren't using cmake like everyone else.
>
> > Regarding r277012, I'm a little confused about the message "Also, fixed up typos in RenderScript code that could not possibly compile." Is this code broken somehow? It build for us with GCC, and green dragon seems fine with it. Is there some particular compiler for which this is broken because everything "Works for Me"?
>
>
> Nope nope you're fine.  I tried to quickly fix my comment in follow ups to my commit message emails.  I looked too quickly at the filenames and figured the error was introduced from the RenderScript change.  It was in fact from Saleem's change.  It was in files that he couldn't compile unless he was on Xcode, so the typos came in there.


Ah! I see the email. Thanks for the clarification.

Best

Luke


Repository:
  rL LLVM

https://reviews.llvm.org/D18059