[Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.
Jim Ingham via lldb-commits
lldb-commits at lists.llvm.org
Tue Jul 26 12:47:45 PDT 2016
Date: Tue Jul 26 14:47:45 2016
New Revision: 276795
Check both private & public states to decide if you need to halt before killing.
We were just checking the public state, but that meant if you were hung in a long
running hand-called function, we wouldn't know to interrupt the process, and we would
not succeed in killing it.
--- lldb/trunk/source/Target/Process.cpp (original)
+++ lldb/trunk/source/Target/Process.cpp Tue Jul 26 14:47:45 2016
@@ -3634,7 +3634,10 @@ Error
- if (m_public_state.GetValue() == eStateRunning)
+ // Check both the public & private states here. If we're hung evaluating an expression, for instance, then
+ // the public state will be stopped, but we still need to interrupt.
+ if (m_public_state.GetValue() == eStateRunning || m_private_state.GetValue() == eStateRunning)
Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_PROCESS));
More information about the lldb-commits