[Lldb-commits] [PATCH] D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

[Muhammad Omair Javaid via lldb-commits]

omjavaid created this revision.
omjavaid added reviewers: labath, Eugene.Zelenko.
omjavaid added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.

This patch allows correct selection of CMAKE_LIBRARY_ARCHITECTURE instead of previously hard-coded value.

All cross builds for 64bit targets with python support enabled will fail in absence of this patch

I am trying to get LLDB host build working on AArch64 native host running ubuntu Xenial 64bit.

My build system is ubuntu 16.04 amd64.

I am able to build LLDB successfully on Ubuntu Trusty 14.04 and 16.04 after applying this patch. 

Please review if there are any possible build breakups due to this patch.

https://reviews.llvm.org/D22771

Files:
  cmake/modules/LLDBConfig.cmake

Index: cmake/modules/LLDBConfig.cmake
===================================================================
--- cmake/modules/LLDBConfig.cmake
+++ cmake/modules/LLDBConfig.cmake
@@ -167,12 +167,6 @@
 endfunction(find_python_libs_windows)
 
 if (NOT LLDB_DISABLE_PYTHON)
-  if(UNIX)
-    # This is necessary for crosscompile on Ubuntu 14.04 64bit. Need a proper fix.
-    if(CMAKE_SIZEOF_VOID_P EQUAL 8)
-      set(CMAKE_LIBRARY_ARCHITECTURE "x86_64-linux-gnu")
-    endif()
-  endif()
 
   if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
     find_python_libs_windows()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22771.65397.patch
Type: text/x-patch
Size: 567 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160725/0065b8c0/attachment.bin>