[Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!
Chris Bieneman via lldb-commits
lldb-commits at lists.llvm.org
Mon Jul 25 10:08:02 PDT 2016
beanz added a subscriber: beanz.
beanz added a comment.
@rengolin, thank you for putting this all together. It is very well thought out, and I really like the shape it took. I have a few minor nitpick comments inline.
Comment at: docs/Proposals/GitHub.rst:58
@@ +57,3 @@
+Git is also the version control most LLVM developers use. Despite the sources
+being stored in an SVN server, most people develop using the Git-SVN integration,
Not to be pedantic here, but do we actually /know/ that most LLVM developers use Git? I suspect that most do, but I don't think we actually have any metrics, so we should avoid using declarative language here. Maybe change 'most' to 'many' here and below.
Comment at: docs/Proposals/GitHub.rst:87
@@ +86,3 @@
+for example development meetings, sponsoring disadvantaged people to work on
+compilers and foster diversity and equality in our community.
In lists you should generally keep the same verb conjugations. Maybe repharse this list to something more like:
> ... hosting developer meetings, sponsoring disadvantaged people... and fostering diversity and equality in our community.
More information about the lldb-commits