[Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

[Mehdi AMINI via lldb-commits]

mehdi_amini added inline comments.

================
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+   well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+   account, with all necessary hooks (history, update, merges).
----------------
rengolin wrote:
> mehdi_amini wrote:
> > > Pre-commit hooks
> > 
> > Won't handle the update of the umbrella.
> > 
> > > Post-commit hooks
> > 
> > Can't handle the update of the umbrella *because of GitHub*, this could be possible with our own hosting of git for instance.
> > 
> Pre-commit hooks are not designed to update the umbrella. Webhooks will be able to update the umbrella with a small external service, as proposed in the IRC.
That's why I asked it to be clearly mentioned somewhere else that on top of "hooks" hosted by github, we will need to maintain our own webservice on our own server to answer updates from theses hooks and update the umbrella, because that's a non-negligible drawback in face of the motivation exposed in the "Why move at all?" section. 
Right now the document does not acknowledge that AFAICT.


https://reviews.llvm.org/D22463