[Lldb-commits] [PATCH] D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file

Oleksiy Vyalov via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 8 10:38:36 PDT 2016

ovyalov added a comment.

In http://reviews.llvm.org/D22081#477746, @labath wrote:

> Thanks for adding the additional checks. Looks good apart from the clang-format changes. This looks like the llvm style. I am not sure how you've run this but it does not seem to have picked up LLDB's `.clang-format` file.
> Are you using git? You need to set `clangFormat.binary` setting to a sufficient new version (ideally the one you've just built), so it knows how to handle our `AlwaysBreakAfterReturnType: All` format. Then `git clang-format HEAD^` should just work (assuming you have git-clang-format in your path).

Yep, apparently I used llvm style formatting - by running clang/tools/clang-format/clang-format-diff.py. Thank you for pointers - I reran clang-format on my patch, it looks better now.


More information about the lldb-commits mailing list