[Lldb-commits] [PATCH] D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 7 02:15:58 PDT 2016

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good.

Please also run clang-format over the patch (also when I don't request it, i tend to forget about that).

Comment at: source/Plugins/Platform/Android/AdbClient.cpp:429
@@ +428,3 @@
+    dst.write (&output_buffer[0], output_buffer.size ());
+    return Error ();
We should close the file and make check for the error flags on the stream to make sure the write was successful.


More information about the lldb-commits mailing list