[Lldb-commits] [lldb] r274490 - Join TestTlsGlobal tests again and use the proper decorator

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 4 02:27:53 PDT 2016


Author: labath
Date: Mon Jul  4 04:27:53 2016
New Revision: 274490

URL: http://llvm.org/viewvc/llvm-project?rev=274490&view=rev
Log:
Join TestTlsGlobal tests again and use the proper decorator

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/lang/c/tls_globals/TestTlsGlobals.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/tls_globals/TestTlsGlobals.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/tls_globals/TestTlsGlobals.py?rev=274490&r1=274489&r2=274490&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/c/tls_globals/TestTlsGlobals.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/tls_globals/TestTlsGlobals.py Mon Jul  4 04:27:53 2016
@@ -27,18 +27,8 @@ class TlsGlobalTestCase(TestBase):
             self.addTearDownHook(lambda: self.runCmd("settings remove target.env-vars " + self.dylibPath))
 
     @skipIfWindows # TLS works differently on Windows, this would need to be implemented separately.
-    @skipIfDarwin # Darwin has its own test below and we don't want it to expected fail with decorator below
-    @unittest2.expectedFailure("llvm.org/pr28392")
-    def test_non_darwin(self):
-        '''Mark as expected fail for all except Darwin or Windows'''
-        self.run_test()
-
-    @skipUnlessDarwin
-    def test_darwin(self):
-        '''Always run on darwin with no expected fail'''
-        self.run_test()
-    
-    def run_test(self):
+    @expectedFailureAll(bugnumber="llvm.org/pr28392", oslist=no_match(lldbplatformutil.getDarwinOSTriples()))
+    def test(self):
         """Test thread-local storage."""
         self.build()
         exe = os.path.join(os.getcwd(), "a.out")




More information about the lldb-commits mailing list