[Lldb-commits] [PATCH] D21648: Make sure to reset to correct platform after TestImageListMultiArchitecture

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 23 18:00:12 PDT 2016

tfiala added a comment.

In http://reviews.llvm.org/D21648#466011, @fjricci wrote:

> I was wondering that as well. I thought there might be some value to testing that the "disconnect->change platform->reconnect" path worked though. I have no problem disabling if that doesn't seem useful though.

I think that kind of test sounds good, but I would separate that into a test that is focused on that element rather than conflating it with this one.

If you can switch this over to skipping the test on remote systems (should be @decorators.skipIfRemote IIRC), that would be ideal.


More information about the lldb-commits mailing list