[Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

Muhammad Omair Javaid via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 16 09:37:46 PDT 2016

omjavaid marked 3 inline comments as done.

Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_size/TestWatchpointSizes.py:104
@@ +103,3 @@
+            self.expect("watchpoint list -v",
+                substrs = ['hit_count = 2'])
labath wrote:
> I guess the intention here is to test both read and write watchpoints. If so, could you state that somewhere (in a comment at least, if it's possible to somehow verify the watchpoint type in code, even better). 
We cant possibly figure out the watchpoint type read or write based on output string emitted when watchpoint is hit.

I have added a comment here which tells the user about why hit count should be updated here.


More information about the lldb-commits mailing list