[Lldb-commits] [PATCH] D21296: [lldb] Fixed race condition on private state thread exit, take 2

Cameron via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 13 14:29:13 PDT 2016

cameron314 added a comment.

@clayborg: Thanks for having a look! I've added Jim Ingham as a reviewer. @jingham, I'd appreciate if you could take a few minutes to look this over.

Right, I'd seen the backup/restore of the thread. As far as I can tell it should still work; the code in `ControlPrivateStateThread` has no idea it's working with a temporary thread, just as it didn't know before (in fact, if you look carefully at the code in the present tip of the trunk, a recent change seems to have introduced a mix of using both `private_state_thread` and `m_private_state_thread`, probably by accident). `m_private_state_thread` cannot be reset to the backup during a control event, since the first thing that's done before restoring the backup thread is to stop the temporary thread.


More information about the lldb-commits mailing list