[Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

[Howard Hellyer via lldb-commits]

hhellyer updated this revision to Diff 59524.
hhellyer marked an inline comment as done.
hhellyer added a comment.

Fix the latest code review comments to remove unnecessary tests for a valid pointer that will always be initialised.

The change to the == operator on SBMemoryRegionInfo required an additional change. It also required adding the == and != operators to MemoryRegionInfo.h, that shouldn't be a problem as far as behaviour goes as nothing can have been comparing MemoryRegionInfo's with == until now. It does mean that SBMemoryRegionInfo's == operator behaves differently to all the other SB* classes operators which do pointer comparison via get() which might not be ideal.


http://reviews.llvm.org/D20565

Files:
  include/lldb/API/LLDB.h
  include/lldb/API/SBDefines.h
  include/lldb/API/SBMemoryRegionInfo.h
  include/lldb/API/SBMemoryRegionInfoList.h
  include/lldb/API/SBProcess.h
  include/lldb/API/SBStream.h
  include/lldb/Target/MemoryRegionInfo.h
  include/lldb/Target/Process.h
  include/lldb/lldb-forward.h
  source/API/CMakeLists.txt
  source/API/SBMemoryRegionInfo.cpp
  source/API/SBMemoryRegionInfoList.cpp
  source/API/SBProcess.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20565.59524.patch
Type: text/x-patch
Size: 20490 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160603/c6bc770c/attachment-0001.bin>