[Lldb-commits] [PATCH] D20565: Add MemoryRegionInfo to SB API

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 1 09:53:33 PDT 2016

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

One last thing: we should default construct a MemoryRegionInfo in all SBMemoryRegionInfo::SBMemoryRegionInfo() constructors so we don't have a make sure to call a non-const ref() method before it the pointer is valid. I know there is other code that does this, but any new code we have been updating to always default constructing an object into the std::unique_ptr just to be safe and avoid potential crashes.


More information about the lldb-commits mailing list