[Lldb-commits] [PATCH] D20760: [tsan] Prefer mangled name when looking up global variable declaration for racy address

Devin Coughlin via lldb-commits lldb-commits at lists.llvm.org
Fri May 27 16:37:20 PDT 2016


dcoughlin created this revision.
dcoughlin added reviewers: kubabrecka, clayborg.
dcoughlin added a subscriber: lldb-commits.
Herald added a subscriber: kubabrecka.

For Thread Sanitizer reports, LLDB tries to find a global variable declaration corresponding to the racy address in order to provide a filename and line number. This commit changes the lookup of the variable to use the mangled name for lookup and fall back to the demangled version if unavailable. This is needed to report locations of races on Swift global variables.

I've also added a test to make sure we look up C++ globals correctly.

http://reviews.llvm.org/D20760

Files:
  packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/Makefile
  packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/TestTsanCPPGlobalLocation.py
  packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/main.cpp
  source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20760.58862.patch
Type: text/x-patch
Size: 4615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160527/b8e17474/attachment.bin>


More information about the lldb-commits mailing list