[Lldb-commits] [lldb] r270961 - fix up lldb-server platform on Apple hosts

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Thu May 26 21:04:52 PDT 2016


Author: tfiala
Date: Thu May 26 23:04:52 2016
New Revision: 270961

URL: http://llvm.org/viewvc/llvm-project?rev=270961&view=rev
Log:
fix up lldb-server platform on Apple hosts

r259714 introduces the transport method into the
URL passed to the gdb-remote stub.  On debugserver,
this is not supported and prevented debugserver from
being launched by lldb-server in platform mode.

This change skips the transport method addition from
r259714 when on Apple hosts.

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp?rev=270961&r1=270960&r2=270961&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp Thu May 26 23:04:52 2016
@@ -132,7 +132,10 @@ GDBRemoteCommunicationServerPlatform::La
     assert(ok);
 
     std::ostringstream url;
+    // debugserver does not accept the URL scheme prefix.
+#if !defined(__APPLE__)
     url << m_socket_scheme << "://";
+#endif
     uint16_t* port_ptr = &port;
     if (m_socket_protocol == Socket::ProtocolTcp)
         url << platform_ip << ":" << port;




More information about the lldb-commits mailing list